[
https://issues.apache.org/jira/browse/FLUME-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227004#comment-13227004
]
[email protected] commented on FLUME-984:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3980/#review5824
-----------------------------------------------------------
Hi Brock, great catch on the lack of a catch-all Exception handler in
SinkRunner. Regarding FatalException, I think it should inherit from
FlumeException since the other exceptions do except for EventDeliveryException,
which should probably be changed to do that. (see also the thread on flume-dev
about checked vs unchecked exceptions... not sure if we exactly came to
consensus on that and if not we should aim for that once and for all to
maintain consistency going fwd)
Regarding the use of FatalException, can you elaborate a little on the use case
for it? When would the system want to allow a Source or Sink to force the
runner to quit?
- Mike
On 2012-02-29 10:42:17, Brock Noland wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3980/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-29 10:42:17)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Catches, logs, and sleeps when a general exception occurs. This is similar
to PollingSourceRunner.
bq.
bq.
bq. This addresses bug FLUME-984.
bq. https://issues.apache.org/jira/browse/FLUME-984
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/FatalException.java
PRE-CREATION
bq.
flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceRunner.java
264fce1
bq. flume-ng-core/src/main/java/org/apache/flume/SinkRunner.java 9e46d87
bq.
bq. Diff: https://reviews.apache.org/r/3980/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. All unit tests pass.
bq.
bq.
bq. Thanks,
bq.
bq. Brock
bq.
bq.
> SinkRunner should catch unhanded exceptions and log them like
> PollingSourceRunner
> ---------------------------------------------------------------------------------
>
> Key: FLUME-984
> URL: https://issues.apache.org/jira/browse/FLUME-984
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.0.0
> Reporter: Brock Noland
> Assignee: Brock Noland
> Attachments: FLUME-984-0.patch, FLUME-984-1.patch, FLUME-984-2.patch
>
>
> If a Sink throws any exception but EventDeliveryException the sink will die.
> We should catch the exception, perhaps backoff a bit, and retry like
> PollingSourceRunner.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
