[
https://issues.apache.org/jira/browse/FLUME-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227181#comment-13227181
]
[email protected] commented on FLUME-984:
-----------------------------------------------------
bq. On 2012-03-05 03:20:15, Juhani Connolly wrote:
bq. > This seems fine... However without the change being propagated to the
sinks to make them throw appropriate errors it will be misleading. Do you think
you could update the sinks/processors to account for the new exception? If not,
we can just push this and I'll open a separate ticket to do that...
You mean update the sink signature so that they know they can throw
FatalException?
- Brock
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3980/#review5608
-----------------------------------------------------------
On 2012-02-29 10:42:17, Brock Noland wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3980/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-29 10:42:17)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Catches, logs, and sleeps when a general exception occurs. This is similar
to PollingSourceRunner.
bq.
bq.
bq. This addresses bug FLUME-984.
bq. https://issues.apache.org/jira/browse/FLUME-984
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/FatalException.java
PRE-CREATION
bq.
flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceRunner.java
264fce1
bq. flume-ng-core/src/main/java/org/apache/flume/SinkRunner.java 9e46d87
bq.
bq. Diff: https://reviews.apache.org/r/3980/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. All unit tests pass.
bq.
bq.
bq. Thanks,
bq.
bq. Brock
bq.
bq.
> SinkRunner should catch unhanded exceptions and log them like
> PollingSourceRunner
> ---------------------------------------------------------------------------------
>
> Key: FLUME-984
> URL: https://issues.apache.org/jira/browse/FLUME-984
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.0.0
> Reporter: Brock Noland
> Assignee: Brock Noland
> Attachments: FLUME-984-0.patch, FLUME-984-1.patch, FLUME-984-2.patch
>
>
> If a Sink throws any exception but EventDeliveryException the sink will die.
> We should catch the exception, perhaps backoff a bit, and retry like
> PollingSourceRunner.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
