[
https://issues.apache.org/jira/browse/FLUME-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258602#comment-13258602
]
[email protected] commented on FLUME-1126:
------------------------------------------------------
bq. On 2012-04-20 21:05:23, Mike Percy wrote:
bq. > Nice work Prasad, looks good overall. I have a couple of nits /
questions inline.
bq. >
bq. > Also, we should file another JIRA to support the RFC5424 timestamp
format that supports fractional seconds, i.e. 2003-10-11T22:14:15.003Z and
2003-08-24T05:14:15.000003-07:00. While we would need to round microsecond
times to the nearest millisecond since our base format is Java milliseconds
since the epoch, today we treat these example timestamp strings as invalid.
Create FLUME-1138 to track the millisecond format.
bq. On 2012-04-20 21:05:23, Mike Percy wrote:
bq. > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java,
line 60
bq. > <https://reviews.apache.org/r/4809/diff/4/?file=103439#file103439line60>
bq. >
bq. > This variable is not ever read.
right, that logic was changed and it's no longer need. will remove it.
bq. On 2012-04-20 21:05:23, Mike Percy wrote:
bq. > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java,
line 267
bq. > <https://reviews.apache.org/r/4809/diff/4/?file=103439#file103439line267>
bq. >
bq. > Not sure what's going on here. Why are we checking for a dash? And
what does startedTimeStamp mean? I don't think it means we have started parsing
the timestamp.
The RFC5424 allows a 'null' timestamp which contains a single '-'
The code is checking for the dash as first character. I guess that variable
name is confusing, will change that.
- Prasad
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4809/#review7093
-----------------------------------------------------------
On 2012-04-20 03:19:50, Prasad Mujumdar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4809/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-20 03:19:50)
bq.
bq.
bq. Review request for Flume, Arvind Prabhakar and Mike Percy.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Support for timestamp and hostname parsing.
bq.
bq.
bq. This addresses bug FLUME-1126.
bq. https://issues.apache.org/jira/browse/FLUME-1126
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java
b0485b1
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java
732cce5
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
653f5eb
bq.
flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java
3a7c486
bq. flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java
8b1f7c5
bq.
bq. Diff: https://reviews.apache.org/r/4809/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated syslog tests to cover timestamp and hostname handling.
bq. Manually tested using syslog4j
bq.
bq.
bq. Thanks,
bq.
bq. Prasad
bq.
bq.
> Support RFC 3164 and 5424 syslog format timestamp parsing
> ---------------------------------------------------------
>
> Key: FLUME-1126
> URL: https://issues.apache.org/jira/browse/FLUME-1126
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.2.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: v1.2.0
>
>
> Support RFC 3164 and 5424 syslog format timestamp parsing for syslog source
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
