[
https://issues.apache.org/jira/browse/FLUME-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263762#comment-13263762
]
[email protected] commented on FLUME-1126:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4809/#review7303
-----------------------------------------------------------
Ship it!
+1
Changes look good Prasad. Some nits noted below. Once you are done with the
revision, please update the patch on the Jira.
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
<https://reviews.apache.org/r/4809/#comment16126>
convention: rename to messageFormats instead of using underscore.
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
<https://reviews.apache.org/r/4809/#comment16125>
convention: please use class name with CamelCase (SyslogFormater)
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
<https://reviews.apache.org/r/4809/#comment16127>
nit: please rename it to initHeaderFormats() instead.
flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
<https://reviews.apache.org/r/4809/#comment16124>
nit: please remove extraneous whitespace.
flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java
<https://reviews.apache.org/r/4809/#comment16128>
nit:trailing whitespace.
- Arvind
On 2012-04-27 14:58:21, Prasad Mujumdar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4809/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-27 14:58:21)
bq.
bq.
bq. Review request for Flume, Arvind Prabhakar and Mike Percy.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Support for timestamp and hostname parsing.
bq.
bq.
bq. This addresses bug FLUME-1126.
bq. https://issues.apache.org/jira/browse/FLUME-1126
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java
b0485b1
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java
732cce5
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
653f5eb
bq. flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java
8b1f7c5
bq.
bq. Diff: https://reviews.apache.org/r/4809/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated syslog tests to cover timestamp and hostname handling.
bq. Manually tested using syslog4j
bq.
bq.
bq. Thanks,
bq.
bq. Prasad
bq.
bq.
> Support RFC 3164 and 5424 syslog format timestamp parsing
> ---------------------------------------------------------
>
> Key: FLUME-1126
> URL: https://issues.apache.org/jira/browse/FLUME-1126
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.2.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: v1.2.0
>
>
> Support RFC 3164 and 5424 syslog format timestamp parsing for syslog source
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
