[
https://issues.apache.org/jira/browse/FLUME-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264086#comment-13264086
]
[email protected] commented on FLUME-1126:
------------------------------------------------------
bq. On 2012-04-27 21:27:56, Mike Percy wrote:
bq. > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java,
line 52
bq. > <https://reviews.apache.org/r/4809/diff/5/?file=104882#file104882line52>
bq. >
bq. > The RFC5424 version field should be a digit followed by a space. So
I think this pattern should be: "(?:\\d\\s)?"; i.e. no [] character class
around in. Worth adding a unit test w/ the example messages from RFC5424 to be
sure it's compliant.
Actually, I just checked and it works as-is. So, nevermind this comment :)
bq. On 2012-04-27 21:27:56, Mike Percy wrote:
bq. > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java,
line 241
bq. > <https://reviews.apache.org/r/4809/diff/5/?file=104882#file104882line241>
bq. >
bq. > Why would the Scanner be closed? Shouldn't this exception be logged
or re-thrown?
Looks like it's not a closed Scanner but it will throw if match() is called
when there are no matches. So, please disregard this too.
- Mike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4809/#review7321
-----------------------------------------------------------
On 2012-04-27 14:58:21, Prasad Mujumdar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4809/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-27 14:58:21)
bq.
bq.
bq. Review request for Flume, Arvind Prabhakar and Mike Percy.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Support for timestamp and hostname parsing.
bq.
bq.
bq. This addresses bug FLUME-1126.
bq. https://issues.apache.org/jira/browse/FLUME-1126
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java
b0485b1
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java
732cce5
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
653f5eb
bq. flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java
8b1f7c5
bq.
bq. Diff: https://reviews.apache.org/r/4809/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated syslog tests to cover timestamp and hostname handling.
bq. Manually tested using syslog4j
bq.
bq.
bq. Thanks,
bq.
bq. Prasad
bq.
bq.
> Support RFC 3164 and 5424 syslog format timestamp parsing
> ---------------------------------------------------------
>
> Key: FLUME-1126
> URL: https://issues.apache.org/jira/browse/FLUME-1126
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.2.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: v1.2.0
>
> Attachments: FLUME-1126-9.patch
>
>
> Support RFC 3164 and 5424 syslog format timestamp parsing for syslog source
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
