[
https://issues.apache.org/jira/browse/FLUME-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294202#comment-13294202
]
Juhani Connolly commented on FLUME-1252:
----------------------------------------
Some comments on the code:
- It looks to me like when there are any failed puts, that the whole
transaction is rolled back, though the succesful puts remain in hbase. I
presume the hope here is to overwrite them once it actually succeeds? Are we ok
with this?
- Configuration isn't documented and the configuration constants are all case
dependent. It would probably be more user friendly to make the config constants
constants and document stuff. We've used Enum.valueOf(confValue.uppercase()) in
many places before...(this is in reference to the configuration of KeyType in
SimpleAsyncHbaseEvent). I think we should really make sure new components
follow the model of providing javadoc that explains the configuration options,
as I've had to trawl through the code several times now to run simple "is this
working" type tests, and it's a huge waste of time. In this case you've
provided a sample config here, which is great... For the reviewers, but doesn't
help anyone actually trying to use it later on. I'll try to make a pass on
documenting all the undocumented components later, but it'd be nice if any new
ones from now on were documented from the start.
- SimpleAsyncHbaseEvent.getActions should probably just switch(KeyType) rather
than a chain of if(keyType == KeyType.XYZ)
The unit test doesn't work on my dev machine(I'm running full tests on a test
VM now, will get back on that if there's a problem there too). I'm attaching
the log. It's probably something local, but I don't think we should need to
spin up a mini-cluster(instead of mocking) for this... Tests take long enough
already, and the HBase project is a clear indicator of the pain that comes when
you start using a minicluster for a lot of tests.
> Asynchronous HBase Sink
> -----------------------
>
> Key: FLUME-1252
> URL: https://issues.apache.org/jira/browse/FLUME-1252
> Project: Flume
> Issue Type: New Feature
> Components: Sinks+Sources
> Reporter: Otis Gospodnetic
> Assignee: Hari Shreedharan
> Fix For: v1.2.0
>
> Attachments: FLUME-1252.patch
>
>
> The current HBase sink is synchronous/blocking. Asynchbase HBase client
> outperforms HTable. It would be nice to have an HBase sink that uses
> asynchbase.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
