----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5350/#review8310 -----------------------------------------------------------
flume-ng-node/src/main/java/org/apache/flume/conf/file/AbstractFileConfigurationProvider.java <https://reviews.apache.org/r/5350/#comment17923> Class.forName(String) throws ClassNotFoundException which gets wrapped by FlumeException. I think the load() of PropertiesFileConfigurationProvider should catch FlumeException or we should throw ClassNotFoundException from create() of DefaultSinkFactory. I believe catching ClassNotFoundException makes more sense and we can throw all the way to load() of PropertiesFileConfigurationProvider - Mubarak Seyed On June 17, 2012, 8:11 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5350/ > ----------------------------------------------------------- > > (Updated June 17, 2012, 8:11 a.m.) > > > Review request for Flume, Mubarak Seyed and Juhani Connolly. > > > Description > ------- > > Added a fix to catch NoClassDefFoundError which was what seems to cause > FileChannel issue. Should fix flume agent hanging due to Hadoop dependency of > HDFS Sink and Recoverable Memory Channel. > > > This addresses bug FLUME-1246. > https://issues.apache.org/jira/browse/FLUME-1246 > > > Diffs > ----- > > > flume-ng-node/src/main/java/org/apache/flume/conf/file/AbstractFileConfigurationProvider.java > 15ee8ad > > Diff: https://reviews.apache.org/r/5350/diff/ > > > Testing > ------- > > > Thanks, > > Hari Shreedharan > >
