> On June 17, 2012, 8:33 a.m., Mubarak Seyed wrote: > > flume-ng-node/src/main/java/org/apache/flume/conf/file/AbstractFileConfigurationProvider.java, > > line 201 > > <https://reviews.apache.org/r/5350/diff/1/?file=111517#file111517line201> > > > > How about this? > > > > try { > > doLoad(); > > } catch (ClassNotFoundException ce) > > logger.error("Error message"); > > } catch (Exception e) { > > logger.error("Failed to load configuration data. Exception > > follows.", > > e); > > }
Actually the agent does not hang because of a ClassNotFoundException, but because of a NoClassDefFoundError. A ClassNotFoundException would have been caught by the current code anyway, since we catch all exceptions, and log an error message. - Hari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5350/#review8311 ----------------------------------------------------------- On June 17, 2012, 8:11 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5350/ > ----------------------------------------------------------- > > (Updated June 17, 2012, 8:11 a.m.) > > > Review request for Flume, Mubarak Seyed and Juhani Connolly. > > > Description > ------- > > Added a fix to catch NoClassDefFoundError which was what seems to cause > FileChannel issue. Should fix flume agent hanging due to Hadoop dependency of > HDFS Sink and Recoverable Memory Channel. > > > This addresses bug FLUME-1246. > https://issues.apache.org/jira/browse/FLUME-1246 > > > Diffs > ----- > > > flume-ng-node/src/main/java/org/apache/flume/conf/file/AbstractFileConfigurationProvider.java > 15ee8ad > > Diff: https://reviews.apache.org/r/5350/diff/ > > > Testing > ------- > > > Thanks, > > Hari Shreedharan > >
