> On June 17, 2012, 8:38 a.m., Hari Shreedharan wrote: > > flume-ng-node/src/main/java/org/apache/flume/conf/file/AbstractFileConfigurationProvider.java, > > line 206 > > <https://reviews.apache.org/r/5350/diff/1/?file=111517#file111517line206> > > > > Actually Class.forName throws ClassNotFoundException if it cannot find > > the class whose class object you are trying to create. If the class you > > are trying to create can be found(like FileChannel), then it tries to > > create classes of all its internal members - when that fails(due to missing > > Hadoop), it throws a class not found exception, which is wrapped in a > > NoClassDefFoundError. > > > > If it was throwing FlumeException it is ok, the exception is caught by > > the catch above the one I just added - and the next time a config update > > happens it would be picked up.
You are right. MapWritable result = new MapWritable(); (in readFields() or toMapWritable() of FlumeEvent) causes to throw NoClassDefFoundError +1 for the patch. Thanks. - Mubarak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5350/#review8312 ----------------------------------------------------------- On June 17, 2012, 8:11 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5350/ > ----------------------------------------------------------- > > (Updated June 17, 2012, 8:11 a.m.) > > > Review request for Flume, Mubarak Seyed and Juhani Connolly. > > > Description > ------- > > Added a fix to catch NoClassDefFoundError which was what seems to cause > FileChannel issue. Should fix flume agent hanging due to Hadoop dependency of > HDFS Sink and Recoverable Memory Channel. > > > This addresses bug FLUME-1246. > https://issues.apache.org/jira/browse/FLUME-1246 > > > Diffs > ----- > > > flume-ng-node/src/main/java/org/apache/flume/conf/file/AbstractFileConfigurationProvider.java > 15ee8ad > > Diff: https://reviews.apache.org/r/5350/diff/ > > > Testing > ------- > > > Thanks, > > Hari Shreedharan > >
