[
https://issues.apache.org/jira/browse/FLUME-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407553#comment-13407553
]
E. Sammer commented on FLUME-748:
---------------------------------
@Arvind:
I'd encourage you to instead consider a visitor based approach where a central
poller visits each component with a context that can hold metric contributions.
The current implementation of exposing counters as MBeans couples the two too
strongly, in my opinion (i.e. the monitoring infrastructure and the way we
count events). I'd also like to leave the door open to instrumentation that is
not just counters (like histograms) and have a single MBean that represents all
metrics for a given component.
If you disagree and move ahead, let's at least try and move toward the open
closed principal with respect to the inheritance model. As it stands now, it
looks like the base class MonitoredCounterGroup needs to know about all
implementations (by way of the enum) which is really, really not nice. I'd
prefer composition over inheritance unless there's a seriously good reason.
> Create metric collection infrastructure
> ---------------------------------------
>
> Key: FLUME-748
> URL: https://issues.apache.org/jira/browse/FLUME-748
> Project: Flume
> Issue Type: Sub-task
> Components: Build, Docs, Master, Node, Shell, Sinks+Sources,
> Technical Debt, Test, Web
> Affects Versions: NG alpha 1
> Reporter: E. Sammer
> Assignee: Arvind Prabhakar
> Priority: Blocker
> Fix For: v1.2.0
>
> Attachments: FLUME-748-1.patch, FLUME-748.trunk.v1.patch,
> Flume_Ganglia_Screenshot.jpg, flume-http-webui.jpg
>
>
> Tentatively marking as v1.2.0 blocker per discussion on flume-dev
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
