Took the liberty to actually do this and followed Jeremias advice to 
KISS.

The new directory layout is just:
test
   |---layoutengine
                  |-- standard-testcases 
                  |-- hyphenation-testcases

To select a group set the fop.layoutengine.testset system property to 
either "standard" or "hyphenation". It defaults to "standard".

I also modified the build.xml to not stop on any Junit errors or 
failures. Instead Ant properties are set and the junit target will 
print a BIG notice that something went wrong or was skipped if one of 
those properties is set. As the junit target is pretty much the last 
target usually run its easy to visually check the result and be alerted 
if something went wrong even if the actual error has scrolled off the 
screen.

I hope this will address some of the concerns raised in  
http://marc.theaimsgroup.com/?t=112914890600004&r=1&w=2.

I am sure all this can be further improved upon but I hope useability 
has moved at least a little bit forward.

Manuel

On Thu, 10 Nov 2005 06:00 pm, Jeremias Maerki wrote:
> As I already told Manuel via IM, I agree with this, although I don't
> quite see the benefit in the "bugs" directory. But I guess it won't
> hurt, either.
>
> On 10.11.2005 08:59:55 Manuel Mall wrote:
> > On Wed, 9 Nov 2005 10:05 pm, Jeremias Maerki wrote:
> > <snip/>
> >
> > > Are there any objections on doing the first release within the
> > > next few days? Is there anything that needs to be done which is
> > > not on the release plan [1] besides the sandbox proposal? Does
> > > anyone see any outstanding legal issues preventing the release as
> > > is? Anything else?
> >
> > I think before the release we need to do something about this:
> > http://marc.theaimsgroup.com/?t=112914890600004&r=1&w=2
> >
> > However, I don't feel like re-opening the discussion as it appeared
> > rather pointless to me. Here is what I suggest to do as a quick fix
> > to the problem:
> >
> > 1. Instead of having 1 directory (test/layoutengine/testcases)
> > containing all layout engine tests split them up according to the
> > resources they require:
> >
> > test
> >    |---layoutengine
> >                   |-- default (our normal set of layoutengine
> > testcases which do not require any special resources) |--
> > hyphenation (those testcases which depend on hyphenation resources)
> >                   |-- fonts (testcases which depend on font
> >                             resources - none yet so this directory will
> >                             not really exist)
> >                   |-- bugs (BugZilla related testcases - I see
> > those only as temporary as these should be integrated
> >                             into the above once fixed)
> >
> > Note: The disabled-testcases.txt file will remain in
> > test/layoutengine and apply to all subdirectories (keep it simple).
> >
> > 2. Create separate targets in build.xml for these.
> >
> > 3. The normal build will only include the targets default and
> > hyphenation (and fonts). hyphenation (and fonts) will be skipped
> > (with a warning) if the resources are not available.
> >
> > I know we could (and should) control all this by adding to the
> > testcase XML, because ideally each testcase should declare the
> > resources it wants (and don't wants) and the testcase engine should
> > check/setup the environment accordingly. But I want to get the
> > release out and the above can be done fairly quickly.
> >
> > WDYT
> >
> > Manuel
> >
> > <snip/>
> >
> > > Jeremias Maerki
>
> Jeremias Maerki

Reply via email to