On Tue, Aug 5, 2014 at 5:16 PM, Warren Young <war...@etr-usa.com> wrote:
> On 7/26/2014 08:53, Eric Rubin-Smith wrote: > >> >> * Code review! >> > > Your talk of state machines suggests that you're instead envisioning a > system where you can't get a checkin into the trunk -- maybe not even into > a development branch -- without someone else signing off on it. If so, > this is a terrible idea. It is possible, with no new features in Fossil, to prevent accidental commits to trunk. Since each developer will be working with a clone of the main repository, you simply do not give your developers commit permission to the main repository. When a developer has a change ready for review, she/he sends a review request with the name of the branch (on his repo). the the integrator (or an automated process) would then pull that branch so the reviewers can review if. Once approved, the integrator (possibly one of the reviewers) would merge the branch in to the trunk. FWIW, I think, behinds the scenes, you would find that VCSs that support approve-before-commit actually accept the (proposed) commit into an automatically created private branch, then move the commit to the target branch (or trunk) upon approval. While this could be implemented either in Fossil or in a "wrapper" for Fossil, the convenience it might provide really only manifests with very simple changes/fixes. But, when you need to iterate the process, you either end up with a new, single commit branch for each iteration, or you have to "pull aside the curtain" to find the branch's id and make further commits to that branch. Also, even if most of your changes/fixes are simple enough for a single commit each, having a real branch to work with makes it easier to manage integration because you can resolve most, if not all, of the integration issues in the branch before merging it into the target branch (or trunk).
_______________________________________________ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
