On 09/22/2013 01:20 PM, Michael T. Pope wrote:
> On Sat, 21 Sep 2013 11:59:08 +0200
> Michael Vehrs <michael.bursc...@gmx.de> wrote:
>> I have widened the EndTurnDialog. It turned out to be easy and
>> straightforward. However, it took me quite a while to figure out that my
>> code was, in fact, working as designed, since the game constantly
>> resized the dialog according to the client option settings from the
>> saved game! You may have suffered from the same problem.
> Indeed I did.  Worse, I had assumed it was not relevant because I have the
> rememberSavedPositions option disabled.  However, it does not apply to
> sizes.  I will add a rememberSavedSizes unless you think it would be
> better to just combine them.

I'm not sure whether people would wish to save only panel positions and 
not panel sizes, or vice versa. It may be best to add another option and 
let the players sort that out themselves. It might also be a good idea 
to add a (debug) command to throw away all saved sizes and positions.

>
>> you need to start a new game in order to see the wider panel, unless you
>> want to edit the saved client options.
> I had to anyway.  There were a bunch of them in options.xml as well.
> However I can now confirm the fix worked and the EndTurnDialog is now more
> sensibly sized at least in new games.
>
>> [locale setting/number handling]
> Goodonya for sorting out that tangle.  TilePopup units are now correct.
>
>
> I can report some progress on modal/non-modal dialogs.  The functionality
> is now good, thanks to a bit of code browsing of the internals of
> JOptionPane.  Appearance is still lame, but there is no obvious
> barrier to copying over or sharing what FreeColPanel does ATM.  The
> current rough plan is that once the new dialogs look good enough
> I will rename FreeColDialog -> FreeColOldDialog, then add the new
> FreeColDialog with just the confirm-dialog functionality, cut
> over their uses to the new code, and iterate through the
> {choice,input}-dialogs, until FreeColOldDialog is an orphan.
>
> Cheers,
> Mike Pope
>

Sounds like a plan.


Regards

Michael


------------------------------------------------------------------------------
LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99!
1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint
2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes
Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/22/13. 
http://pubads.g.doubleclick.net/gampad/clk?id=64545871&iu=/4140/ostg.clktrk
_______________________________________________
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Reply via email to