On 09/22/2013 10:38 AM, Michael Vehrs wrote: > On 09/18/2013 10:12 AM, Michael T. Pope wrote: >> In git.eb4564c have got rid of another FreeColDialog, the one that >> displays a group of ModelMessages. The replacement uses the >> (surprisingly rarely used) InformationPanel, to which I have added >> optional buttons to display the source of the message (recovering >> functionality lost when dropping the dialog). This is rather >> preliminary, and could well be generalized --- I intend to revisit it >> after a bit of play testing. As usual though, I have just brutally >> tacked on another graphic element with minimal thought to the layout, >> so InformationPanel could do with review from the MigLayout expert. >> >> Meanwhile in testing today I can confirm that unit labelling out of >> TilePopup is improved (Artillery, Wagon Train, Treasure Train, ships, >> Free Colonist, Soldier (Free Colonist), Pioneer (Free Colonist), >> Master Carpenter, Hardy Pioneer are all ok now), but I am still seeing >> plural Jesuit Missionaries, Veteran Soldiers and Seasoned Scouts. >> The EndTurnDialog is also borked --- is it time to replace >> Unit.getFullLabel with Messages.getLabel? >> >> Speaking of EndTurnDialog, IMHO the default width is a bit narrow given >> that locations like "High seas east of Nieuw Amsterdam" are quite >> common. However my first two guesses of what to change here proved to >> be wrong. >> >> Cheers, >> Mike Pope > This is pretty strange. When running MessagesTest, all strings are > expanded correctly. However, this is not the case in-game. It seems that > the plural rules for my locale (possibly all locales) are not properly > set up. I need to investigate further. > > At any rate, we should not replace Unit.getFullLabel() without checking > the string templates used, since they might include the player nation. > > > Regards > > Michael
It seems that the number rules are set twice. Once on the basis of the system locale, and a second time on the basis of the language option. In principle, this is correct. However, we must not attempt to do that if the language option is set to "automatic". I have added a check to Messages.java, but I think it would be better to avoid the problem at an earlier point. I have no idea how long this problem has existed, but I am sure that my recent work on Unit labels only triggered the bug. Regards Michael ------------------------------------------------------------------------------ LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/22/13. http://pubads.g.doubleclick.net/gampad/clk?id=64545871&iu=/4140/ostg.clktrk _______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
