Hi, > > I discovered a new problem with it: I can not find splash.jpg inside > > the precompiled .zip. > > I have been meaning to ask about splash.jpg. It looks out of place to me > at the top level of the git tree. Can we put it somewhere better?
I think the reason its there is that its needed early on in the startup process of the game to show activity and to ensure it is always found. So its placed near the FreeCol.jar, with a hardcoded position in FreeCol.java, which can only be overwritten through the --splash option, Then its directly loaded in displaySplashScreen, which gets called even before the ResourceManager is initialized. As we support movable a data folder I would be wary of moving it there. It might be possible to shove it into the jar and add some magic to read it out of that, but is it really worth doing? I found another file that seems unused, data/freecol.png. Visually it is extremely similar to data/base/frame_icon.png, but has a different filesize. I grepped for the name and its only showing src/net/sf/freecol/tools/DesktopEntry.java. I guess this is an unused tool and therefore an unused file, as we have a premade .desktop file in packaging/common and it references some .xpm file there. I guess, I could exclude this in the base files for distribution? Or would you completely delete both? You expect a longer delay from BR#2876 (or the SF outage)? Would it be sufficient to tell people to delete their options.xml if they get a problem and fix it later? Greetings, wintertime ------------------------------------------------------------------------------ _______________________________________________ Freecol-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freecol-developers
