Hi,
I think that would be more like a hack and not the right way of doing it.
The look and feel stuff (IIRC in plaf folder) is the place where widgets get customized globally, but its weird und I never saw through it completely.
The problem is that a widget may be reused and may need background in one instance and no background in another instance, and both methods would change it for the whole class.
Thats why it probably needs to be set when creating that instance, which is still better than circumventing the system thats in place, checking a redundant bool and overriding on every repaint.
Greetings,
wintertime
Gesendet: Mittwoch, 05. Oktober 2016 um 03:15 Uhr
Von: "Caleb Williams" <cale...@gmail.com>
An: "FreeCol Developers" <freecol-developers@lists.sourceforge.net>
Betreff: Re: [Freecol-developers] open bug review
Von: "Caleb Williams" <cale...@gmail.com>
An: "FreeCol Developers" <freecol-developers@lists.sourceforge.net>
Betreff: Re: [Freecol-developers] open bug review
BR#2911* I reviewed the places where this occurs due to code and in may cases it's a small overlay with the "new" background behind a small section. One place that I don't really like the overlay is on the buttons. It does a great job of letting you know there is something new there, but it I almost feel as if a different texture would be a great way to make this stand out. Something darker perhaps. I also looked at possibly using a solid color background for readability purposes, but the colors I choose did work from what the color "should look like" to when you input that color as an RGB value. Hopefully in the next couple of days I can re-run over the some of the panels and see if I see any egregious errors.
Still looking at this, but it's possible that for certain panels or sub-panels that we may need to override paintComponent(Graphics g) so that we do not paint in the FreeCol background rather than the setOpaque(boolean isOpaque) method call mentioned earlier in the bug report itself. I have not yet experimented further with this idea.
Thanks,
Caleb R. Williams
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
