On Sun, 27 Nov 2016 15:21:55 -0500 Dong Kim <dong...@andrew.cmu.edu> wrote: > I had a few more questions about ticket #43. In order to display EU selling > price, we are currently creating a new string to append > to Messages.message(item.getLabel()), and were wondering if we would need > to manually add Messages.key = value in all FreeColMessages.properties > files in /data/strings, or just simply keep the appended string.
FreeColMessages.properties is the master messages file. The translators use that to make the internationalized versions thereof in .../data/strings. Do not edit those, only the master messages file. > In addition, we were thinking that users may be interested in both EU > buying and selling price when interacting in these trade/negotiation > dialogues, but we weren't sure if this was necessary. I do not think so, both would probably be more confusing and cluttering. When there is some goods to buy/sell all you are immediately worried about is whether you can get a better price elsewhere. IIRC the dialogs are specific to sales/purchases, so on a sales dialog only display selling prices and vice versa. > We also realized that this may lead to overlapping text or other unexpected > formatting in the UI if the text becomes too long, especially if the text > is in a button. Where should we look in the code to manage this? Hopefully wintertime can comment here. I try to keep away from UI issues. Generally though, where the text gets too long it can often be simplified by using a (small) image, particularly for goods. > Would it > be possible to dynamically change the size of panels and buttons > according > to the length of the text, or at least preserve text wrapping, if not done > so already? I doubt it will be possible or desirable to change sizes of existing elements. IIRC FreeCol generally tries to have the full text for buttons ready at the point of creation thus allowing the Java libraries to size them suitably. Cheers, Mike Pope
pgpRXVGKi2bKw.pgp
Description: OpenPGP digital signature
------------------------------------------------------------------------------
_______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
