Hi Eric,

> Now I would like to know how long each of those bugs has been
> in FDISK, can you see that in change logs or by comparing your
> version to various older versions? It must have been ages :-o

I will try to find out and leave a note in CHANGES.md for all critical 
(potential data loss) errors since when the error exists.

In the last hour I found a new bug:

Critical: Fix a partition location and size calculation error triggered when a 
new logical partition is created after deleting the first logical (since at 
least 1.2.1)

It was a one liner to fix but hard to spot:

https://github.com/boeckmann/fdisk/commit/95e102270117b4d79430433da1948b31d8c35947

The error was that pDrive->ptr_ext_part is a pointer to the extended partition 
itself and not a pointer to the logical drive, so the test if the logical 
partition was empty returned always returned false even it was actually true. 
After replacing with pDrive->log_drive[0] it seems to work correctly and to me 
makes logically sense.

Would be glad if someone could double check.

Greetings, Bernd



_______________________________________________
Freedos-devel mailing list
Freedos-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freedos-devel

Reply via email to