...
I may send you my edition of config.c (private, I suggest?), but it not
the last edition (I continue to work on it).
please do
...
and add own comments. For example:
KJD> yes, I viewed yours, the original, RBIL, and the code and selected
KJD> the one that seemed the most clear, being more verbose if necessary.
Hm, I look at RBIL. Looks, like there is another ambiguite (or even
wrong) description. :(
In the future I will be more careful and try to validate descriptions
with other resources.
PS: There are also other re-changes in compare to original and my edition.
For example, I describe `drive' parameter for all functions (as in dsk.c) as
UBYTE (this gets better code) and return type as `int' - in your edition
While the drive parameter is an unsigned byte, it is actually passed in
as a word, and the prototypes in dsk.c at present still indicate this.
So instead of using UBTYE in one place (floppy.asm) and WORD in another
(dsk.c), I maintained the use of WORD. No code is effected, as these
are strictly changes to comments. When I apply your dsk.c patch 10,
which does change the prototypes, I will change floppy.asm to match.
this is no so. Also, I think, explaining in comments for "sbb al,al" that
"Al=-CF" is not good. This is same, as write next:
int i = ...
i++; /* increment i */
My comment isn't AL=-CF it is AL=-CF={-1,0}, the comment is
saying that after the sbb call, AL is either -1 or 0. The -CF simply
clarifies that only carry determines the actual value.
(BTW, you preserve comment in "mov ah,0 ; zero out ah"). Also, you preserve
sure its an obvious comment, but how does it adversely effect anything?
wrong comment "cylinder number (lo only if hard)" - this is complete
cylinder number, not its "lo part". Also, "count to read/write" is wrong
corrected
comment, because there is code for "format" and "verify" (same for
how about 'count of sectors to read/write/...'
fl_lba_readwrite()). Also, you remain "(Zero transfer count)" and "force
into < 255 count", whereas AL (AL only, AH cleared!) returns error code, not
"transfer count".
ok, adjusted, I read this comment as extending al into ax without sign
extension.
PPS: Also, there are cosmetic remarks (from me :): in some places you
preserve my tabulations (though, before some comments you lost one - see,
for example, "mov ah,18h"), in other places you preserve trailing spaces
(even on empty lines)...
While I will commit some, I prefer to not make whitespace only changes.
it also depends on how I apply a given patch.
Jeremy
-------------------------------------------------------
This SF.Net email is sponsored by The 2004 JavaOne(SM) Conference
Learn from the experts at JavaOne(SM), Sun's Worldwide Java Developer
Conference, June 28 - July 1 at the Moscone Center in San Francisco, CA
REGISTER AND SAVE! http://java.sun.com/javaone/sf Priority Code NWMGYKND
_______________________________________________
Freedos-kernel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/freedos-kernel
