Hi Bart, > In any case, I appreciate that a bug was found in ludivmul.inc so do I
> What I don't like is that the fix from Arkady (for the 1000th time...) > does 3 things at the same time -- formatting, fixing, and optimizing. neither do I like that. > This makes it impossible to see where things are really fixed. See the > following is enough: > --- ludivmul.inc.~1.2.~ Sun Jan 27 14:13:07 2002 > +++ ludivmul.inc Tue Jul 20 00:35:31 2004 > @@ -88,10 +88,12 @@ > pop bx ; get dividend lo-word > mov cx, ax ; save quotient > mul di ; quotient * divisor hi-word (low only) > + push di ; save divisor hi-word > xchg ax, di ; save in di > mov ax, cx ; ax=quotient > mul si ; quotient * divisor lo-word > add dx, di ; dx:ax = quotient * divisor > + pop di ; restore divisor hi-word > sub bx, ax ; dividend-lo - (quot.*divisor)-lo > mov ax, cx ; get quotient > pop cx ; restore dividend hi-word thanks for that. I was going to analyse it was well to find the REAL difference to apply to my kernel branch, your effort saves me some time and it's again remarkable how little changes are needed wrt. the 200+ line diff's arkady sends. > I'm sorry but I simply don't have the time to go through all the other > patches. neither do I - specially if they are 90% completely useless formatting changes, 9% introcing LPVOID and Cstr data types, with (at most) 1% hidden gem inside. > If they were reduced to just bug fixes I'll promise that I'll > have another look though -- I still monitor the mailing list every now and > then. Guys *any* project that wants to be close to a 1.0 release must be > in deep freeze, a stabilation, that means that we should really freeze the > mainline kernel for anything but bug fixes. No optimizations, no > reformatting, no new fancy macros, no nothing but bug fixes with the > minimal amount of lines changed. 110% agreed. > Of course feel free to have your own > branch, but I don't think it's in the interest of the project to > use that for a 1.0. > So I can make a deal, you isolate your bug fixes and I'll return and be > friendly, or you don't and I'll simply disappear. It's that easy. well - I maintain such a kernel branch; however not sure if I catch every hidden gem... of course source is available on request. tom ------------------------------------------------------- This SF.Net email is sponsored by BEA Weblogic Workshop FREE Java Enterprise J2EE developer tools! Get your free copy of BEA WebLogic Workshop 8.1 today. http://ads.osdn.com/?ad_id=4721&alloc_id=10040&op=click _______________________________________________ Freedos-kernel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/freedos-kernel
