On Wed, 27 Dec 2000, Mark J. Roberts wrote:
> On Wed, 27 Dec 2000, Scott Gregory Miller wrote:
>
> > > To add support for MSKs to RequestClient, the obvious place to add it is
> > > ClientUtil.getKey, but I would have to overload it with another version
> > > that takes a MapHandler as an argument, and that's ugly and inefficient,
> > > because the key might not even be a MSK. So I could add a isMSK method to
> > > ClientUtil that takes the key string and checks. I'd do it in fillBuckets
> > > before the ClientKey is initialized, and if it returns true, I'd
> > > instantiate a MapHandler and run the key string through it first.
> >
> > I don't think having a MapHandler as an argument to ClientUtil.getKey is
> > too terrible. Why not have a static pointer to the MapHandler somewhere
> > so thtat ClientUtil.getKey can call the maphandler if it finds out the key
> > is a mapKey. This would keep the code out of the actual clients and keep
> > it in the library.
>
> Right now the MapHandler's constructor takes a Params object, but I should
> remove that and make Params an argument of MapHandler.lookup.
>
> Where should I put the static pointer? Client.java?
Thats probably the most logical place now.
_______________________________________________
Freenet-dev mailing list
[EMAIL PROTECTED]
http://lists.sourceforge.net/mailman/listinfo/freenet-dev
