Viggo Fredriksen wrote: > Hi! Hi
> Attached is a patch for a new detached player.
This looks so cool. But we need to define a default key button (not
only keyboard) for the control box.
> It's mostly finished but it has a serious bug which I can't seem to
> find the reason for. I get <Fatal python error: Deallocating None>
> in my DetachbarAnimation after it's been running for a while. This
> might be a mevas error for all I know, so I don't want to spend any
> more time pulling my hair over this.
Define 'after a while'. I works ok here. Maybe it depends on the text
you draw?
> self.itemcanvas.set_image(gui.Text(elapsed, (0,0), size, self.elapsed_font))
I may understand it here because you replace the image.
>> self.canvas.image.clear()
>> self.canvas.draw_image(obj, src_pos=srcpos)
But here? Very strange. I hope Tack will be back again soon to have a
look why this happens. It looks like a bug in pyimlib2.
> Am I doing something horribly wrong here?
No, looks good.
> About the changes:
> - Removed detachbar.py
> - Merged new detachbar with detach.py (detachbar is shown based on a plugin
> activation argument). It no longer shows up in the menu, instead it utilizes
> the new controlmanager.
Good. I changed some stuff in the eventhandler so that you don't need
to show() the menuw. By calling p.hide(), the eventhandler know sees
that no application has the focus and set the focus to the last
application below p.
> - Added a new class ControlManager for managing different controls.
> The class basicly listens to TOGGLE_CONTROL events and shows/hides
> the registered controls. (better naming for this class?)
Nice, very nice. Maybe not use the osd for displaying the text but
draw it just below the control box? And handling it as popup box is
exactly the way to go.
> - Added ButtonPanel as an example for use with the ControlManager, this is
> also the one I use to create the audio detached control. It's not pretty,
> but I didn't have any good ideas for how it should look.
Some problem here.
In CVS in 5 minutes, thanks again.
Dischi
--
I think there's a world market for about five computers.
-- attr. Thomas J. Watson (Chairman of the Board, IBM), 1943
pgpIoDJXaFsm4.pgp
Description: PGP signature
