Chandan Pitta wrote: > On 1/8/07, Duncan Webb <[EMAIL PROTECTED]> wrote: >> Chandan Pitta wrote: >> > On 1/7/07, Duncan Webb <[EMAIL PROTECTED]> wrote: >> >> Chandan Pitta wrote: >> >>> On 1/5/07, Duncan Webb <[EMAIL PROTECTED]> wrote: >> >>>> Chandan Pitta wrote: >> >>>>> What happened to the images? The pop-up window shows only scaled >> >>>>> image. I see that the javascript for openfoto has changed and is >> >>>>> causing the browser to scale the image. Can someone take a look >> at it. >> >>>>> Is it part of a larger fix that is coming later? >> >>>> I had to commit Wout's patches otherwise your patches will not >> succeed, >> >>>> there need to be a fix here. >> >>> I see. Is Wout fixing this issue? I can take a look at it otherwise. >> >> Wout has provided a patch this has fixed the problem :) >> > >> > Good! Thanks Wout. >> >> Not perfect, the window needs closing otherwise the next image clicked >> reuses the window but doesn't resize it. > > > Ok, finally I was able to get to this issue. Fixes are as follows: > > 1. If the pop-up window is already open it will be resized to fit to > the new image. > 2. If the image is larger than the screen, then the window is > maximized to the screen and the image is scaled to fit inside it. No > scrollbars. > 3. Previous patch caused the image to change aspect when the image > does not fit in the screen. I fixed it such that the image scales > while maintaining aspect. > 4. Brings the window into focus (useful in case it is not closed > between clicks). > > Please check the patch and commit.
A bit more work than I expected to update the cache so that it works in the same way as normal cache. Especially, as I hadn't committed Wout's patch until too late, meaning that I had to apply the patch by hand. Let's hope that I didn't break anything else in the process. Quite a few files changed to this and a few function names too. Would you be so kind as to test it, my tests look good. One thing that is puzzling me is why is it slow, any idea. The same fix that you did to bring the window to focus for the images could be applied to the remote on the index page. BTW great job with the images. Duncan ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Freevo-devel mailing list Freevo-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freevo-devel
