> 3. Images files in cache have double extensions, like my_image.png.png
> and in some extreme cases like for gif files there are 3 extensions,
> like my_image.gif.gif.jpg. So I made some changes so that the cached
> image filename will be exactly the same as the original image except
> for the case of gif files.
The double extensions are important for cache when removing cached
images for images that no longer exist, we need to get the exact
filename. The bugs in imlib2 incorrectly saving files with upper case
and .gif extensions.
I am sorry, I should have asked you first about this before I changed
the code. Makes sense.
>> One thing that is puzzling me is why is it slow, any idea.
>
> What is slow? I lost the context here. Do you mean the "freevo cache"
> or the webpage loading or something else?
The webserver loading pages is very slow.
I think we need minimize the use of metadata.parse as it is quite slow
and minimize opening images, this is slow too.
The height and width of images seems to be already cached as
info['height'] and info['width']. I haven't changed this but have left a
print in there so you can see what is happening.
You are right, the size is already cached and it makes sense to use
it. I made this change and removed the print statement.
>> The same fix that you did to bring the window to focus for the images
>> could be applied to the remote on the index page.
>
> I did this fix also. Now it is your turn to test :P
I can't see the use of the play, pause and stop buttons on the index
page, we can get rid of these.
I removed these in the patch. Please review the code and apply.
Regards,
Chandan
I shall commit the changes now.
Duncan
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Freevo-devel mailing list
Freevo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freevo-devel
Index: src/www/htdocs/library.rpy
===================================================================
--- src/www/htdocs/library.rpy (revision 8966)
+++ src/www/htdocs/library.rpy (working copy)
@@ -483,8 +483,7 @@
if not os.path.exists(scaled_image_path):
size = util.create_www_thumbnail(item)
else:
- size = imlib2.open(item).size
- print 'DJW:size:',size, 'w:', info['width'],
'h:',info['height']
+ size = (info['width'], info['height'])
image_link = self.convert_dir(filepath)
scaled_image_link = self.convert_dir(scaled_image_path)
fv.tableCell('<div class="image"><a
href="javascript:openfoto(\''+image_link+'\','+str(size[0])+','+str(size[1])+')">'\
Index: src/www/web_types.py
===================================================================
--- src/www/web_types.py (revision 8966)
+++ src/www/web_types.py (working copy)
@@ -569,10 +569,6 @@
</script>
<br />
<table border="0" cellspacing="0" cellpadding="0" class="remote">
- <tr><td class="remote"><button class="remote" accesskey="p"
onClick="send_code('PLAY');">PLAY</button></td>
- <td class="remote"><button class="remote" accesskey="u"
onClick="send_code('PAUSE');">PAUSE</button></td>
- <td class="remote"><button class="remote" accesskey="s"
onClick="send_code('STOP');">STOP</button></td>
- </tr>
<tr><td colspan="3" align="center"><a
href="javascript:openremote()">Freevo WebRemote</a></td></tr>
</table>
"""
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Freevo-devel mailing list
Freevo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freevo-devel
