On 2008-12-29, Miklos Vajna <[email protected]> wrote: > Hm. Adding such a warning is a good idea, though I would add a reference > as well, like: > > '# WARNING! Machine generated file, do not edit; edit > /etc/sysconfig/network/foo instead' - where foo would be replaced by the > current network profile. > > Netconfig currently provides a way to have all your network passwords in > one directory (ie WPA and WEP ones), and your patch breaks this. > However, I think there is nothing wrong with having an option not to > update /etc/wpa_supplicant.conf, for those who know what they are doing. > This is already possible with using the example you touched in your > patch. As the note says in the manpage, the builtin example just > provides a builtin way for most users, if you want something special, > then use the example. > > (A great feature of netconfig is that in fact the only hardwired feature > is the ifconfig up/ifconfig down part, everything else can be disabled > and replaced by your own hooks in case you don't like the builtin > iwconfig/dhcp/wpa features.)
These days having multiple wireless networks configured is not some obscure geeky black magic "for those who know what they are doing", it's a very basic need for anyone whose computing device is more mobile than a desktop PC. This should be straightforward to configure for the average "intermediate user" who is the declared target auidence of the distro. I mean, it should be possible to do w/o RTFM. OK, you insist on having passwords at a central place... Maybe it should be made possible to have several essid/wpa_psk pairs within the section of a particular interface? It could be parsed into a linked list... And the dialogue UI could be tweaked so that it becomes possible to add further wireless networks to one interface via it -- which would be a really RTFM-free solution (unlike the one I proposed). > So, would it be OK for you to just add the above warning, and use the > provided example in case you or somebody else really wants to manage > her wpa passwords in /etc/wpa_supplicant.conf? Well, now _I_ am fine... but I got here the hard way :) First I went through the experience I pictured with the short story about my fictional heroine, then I coded angrily to get to the permanent wpa_supplicant.conf, then I realized that the docs should be adjusted too, then I found the relevant part of the docs -- now I know of that pre/post hooky stuff, so I can get along fine with vanilla frugalwareutils as well. I just meant to point out something which IMHO can be qualified as an UI design glitch (and make an attempt to convince myself that my hacking investment was not in vain by trying to have my patch accepted ;) ). Yes, a nice warning in the generated wpa_supplicant.conf seems to do the job, too. > Ah and a minor nit, you can use git format-patch as described here: > > http://frugalware.org/docs/getting-involved#_downloading_and_setting_up_the= > _repositories > > which just makes our life easier. OK, just two questions: - If some rationale or explanation is needed, where to put that? Or good patches are self-explanatory anyway? - Here is one ML for several projects. git format-patch adds a subject of the form "[PATCH]<commit description>", with no reference to the project. Is it OK with you that you can't tell which project is the patch for by just looking at the subject? Regards, Csaba _______________________________________________ Frugalware-devel mailing list [email protected] http://frugalware.org/mailman/listinfo/frugalware-devel
