On Mon, Dec 29, 2008 at 11:55:31PM +0000, Csaba Henk <[email protected]> wrote: > (Another thing I learnt the hard way -- first I wrote a script > to parse "iwlist scan" output and compare that with a list of wireless > network configurations, then, like netconfig, generate a wpa_supplicant > configuration, and call wpa_supplicant on it. Then I took the effort to read > wpa_supplicant.conf(5) (see in particular the last paragraph in OVERVIEW)... > duhh :/ )
:-) > Hmm, comparing your plan to my patch: > > Both includes: > > - essid / wpa key management goes out of the scope of > /etc/sysconfig/network As far as I see your patch does this unconditionally, while my plan was to conditionally do it (while keeping the default 'no'). > Your includes: > > - Overloads the semantics of the directive wpa_psk. While it's > not likely that one would use "config" for the wpa key, it's > still not too nice IMHO. Right, your patch adds a new directive for it, which is cleaner. > - Makes changes to the dialogue interface, and in fact, makes > it more difficult. Newbies won't understand that techie lingo > about wpa_supplicant, they might be confused, or annoyed by > having to hit enter one more time. > > (And just to nitpick: there is no "existing wpa_supplicant.conf" at > install time ;) I say "nitpick" because the final wording can of course > be chosen in a way which is also appropriate at install time.) Fine, given that I personally don't need this new mode, I won't fight for supporting it from the curses interface. ;-) I'm sending a cleaned up version of your patch which I would like to include. The functionality does not differ too much, the diffstat differs a bit: old: doc/netconfig.txt | 11 +++++------ libfwnetconfig/libfwnetconfig.c | 37 +++++++++++++++++++++++++++---------- libfwnetconfig/libfwnetconfig.h | 1 + 3 files changed, 33 insertions(+), 16 deletions(-) new: doc/netconfig.txt | 14 +++++++++++++- libfwnetconfig/libfwnetconfig.c | 9 ++++++--- libfwnetconfig/libfwnetconfig.h | 1 + 3 files changed, 20 insertions(+), 4 deletions(-) Let me know if you're OK with that.
pgpqZK7wO8g2W.pgp
Description: PGP signature
_______________________________________________ Frugalware-devel mailing list [email protected] http://frugalware.org/mailman/listinfo/frugalware-devel
