I just saw something *big* case PM_OP_PS: ret = pspkg(pm_targets); break; and then the declaration is: int pspkg(); You should add the void or the pm_targets type to the call. (maybe all our () prototype should also be changed to (void) ?)
Smaller issues: * ps_parse lacks a static in the declaration. * lsof is executed using execvp which might be problematic since it exports all the environment, leading to potentioal locale issues at least. * on execvp failure child process should die not return * The parent should also check the fdopen return, just in case the child was faster, and execvp failed (leading to an appempt to read a pipe without writer, which is an error) * end_lsof should be input values guarded (checking NULL file and 0 pid) * struct __ps_t don't have to be library public, and pid should be of pid_t type. I wait review for now, maybe some more on the next round ;) > On Mon, May 09, 2011 at 02:52:01AM +0200, Miklos Vajna > <[email protected]> wrote: >> v2, deal with empty output. > > v3, it detects not renamed files as well. Do a pacman -S glibc, run > pacman-g2 -P and see what processes still use the old glibc. :) > _______________________________________________ > Frugalware-devel mailing list > [email protected] > http://frugalware.org/mailman/listinfo/frugalware-devel > _______________________________________________ Frugalware-devel mailing list [email protected] http://frugalware.org/mailman/listinfo/frugalware-devel
