Hi,
Ideally, the user manager should not/must not
depend on the ftp server implementations. If should be
self sufficient. That is the reason I am against the
idea of getting FileSystemView from FtpRequest object.
If we observer any operating system, file has
certain relationship with the user. So the user was
the obvious choice.
The second part is not very clear. Can you please
elaborate this part so that I can understand the
problem.
I have not applied the patch, because I think it is
better to discuss about it little more. May be we can
start a mail-thread with the problem and different
possible solutions. When everybody is at the same
platform, then only we should do a major change.
Thanks,
Rana Bhattacharyya
--- Sergey Vladimirov <[EMAIL PROTECTED]> wrote:
> Hi, Pierre,
>
> >Another thing is FileSystemManager that return a
> FileSystemView for a User
> >and why not for an FtpRequest?
> I agree. We need to take care of, for example, IP
> adress. In fact I changed
> it long time ago in my workspace, but not commited
> to CVS. I think I have it
> as part of patch for
> http://issues.apache.org/jira/browse/FTPSERVER-19
> but may be I wrong.
>
> >I have the following problem with the UserManager I
> open a connection to
> >another server and I store it into the User that
> will be returned by method
> >getUserByName, an interesting thing could be that
> when you call
> authenticate
> >or getUserByName methods from UserManager to pass
> the FtpRequest.
> I'm sure the problem is that we store User in
> FtpRequest right after USER
> command, as some fake user, and retrieve new user
> from UserManager after
> authorization complete (PASS command).
> I fixed this behaviour by adding Credentials to
> FtpRequest, in patch for
> http://issues.apache.org/jira/browse/FTPSERVER-19
> ...but as I said before it is not in SVN yet.
>
> --
> Sergey Vladimirov
>
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
