On 20 May 2003 14:55:08 +0200, Olivier Chapuis wrote: > > On Tue, May 20, 2003 at 02:01:55AM +0000, Mikhael Goikhman wrote: > > > > I thought about weither individual window style entries (one per window) > > could be stored in a separate list and never be merged (only deleted), > > i.e they always take a precedence. But this seems to be non intuitive, > > probably a user wants all terminals to be affected by "Style XTerm > > Borders" even the ones that were individually defined to be borderless, > > so the logics in the patch (merging both Style types together) is good. > > In fact I am not sure. Take this example: a user want a window with > NeverFocus (an xterm as he has executed less -f .xerror and maybe > later he will want to get SloppyFocus again on it if he quit less). > So he set NeverFocus on this window (by id) ... then he reload some themes > component which leads to "Style * SloopyFocus" ... the log xterm > has SloppyFocus. Bad. > > The two approach seem reasonable.
Yes, but then I predict the following scenario may happen too often. Someone is surprised that some window does not accept focus and Style or FocusStyle do not work on it, he tries several possibilities with all names shown by FvwmIdent, then he gives up, asks on the mailing list and we all debug this situation. At the end it happens that the problematic window was set NeverFocus individually several months ago and the only way now to undo this is to execute "WindowStyle SloppyFocus" on it. Another argument for the "total merging" approach is that "theme switching" should not be different than Restart, and on Restart all individual window styles are lost (at least now). Finally, if in the future all state commands are replaced by WindowStyle, I would think this implies the first approach, at least by default. I agree that two approaches seem reasonable, but I think the first is more intuitive (even if it is bad in some situations). It is possible to give an argument to note the second approach like: WindowStyle Permanent Stick This may be done in the future (adding a boolean to a style identifier). For now I would leave the functionality as in the patch. Regards, Mikhael. -- Visit the official FVWM web page at <URL:http://www.fvwm.org/>. To unsubscribe from the list, send "unsubscribe fvwm-workers" in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
