2009/11/27 Iustin Pop <[email protected]>: > --- a/lib/bdev.py > +++ b/lib/bdev.py > +def _CanReadDevice(path): > + try: > + f = open(path, "r") > + try: > + f.read(128*1024) > + finally: > + f.close() > + return True
Please use utils.ReadFile(path, size=128 * 1024), rest LGTM.
> + except EnvironmentError, err:
> + logging.warning("Can't read from device %s", path, exc_info=True)
> + return False
