2009/12/1 Iustin Pop <[email protected]>: > Interdiff: > diff --git a/lib/bdev.py b/lib/bdev.py > index 09b5b14..eda59ed 100644 > --- a/lib/bdev.py > +++ b/lib/bdev.py > - f = open(path, "r") > - try: > - f.read(128*1024) > - finally: > - f.close() > + utils.ReadFile(path, size=128*1024)
Please use spaces around operators.
> return True
> except EnvironmentError, err:
> logging.warning("Can't read from device %s", path, exc_info=True)
LGTM
