On Fri, Nov 27, 2009 at 03:22:36PM +0000, Michael Hanselmann wrote:
> 2009/11/27 Iustin Pop <[email protected]>:
> > --- a/lib/bdev.py
> > +++ b/lib/bdev.py
> > +def _CanReadDevice(path):
> > + try:
> > + f = open(path, "r")
> > + try:
> > + f.read(128*1024)
> > + finally:
> > + f.close()
> > + return True
>
> Please use utils.ReadFile(path, size=128 * 1024), rest LGTM.
Interdiff:
diff --git a/lib/bdev.py b/lib/bdev.py
index 09b5b14..eda59ed 100644
--- a/lib/bdev.py
+++ b/lib/bdev.py
@@ -73,11 +73,7 @@ def _CanReadDevice(path):
"""
try:
- f = open(path, "r")
- try:
- f.read(128*1024)
- finally:
- f.close()
+ utils.ReadFile(path, size=128*1024)
return True
except EnvironmentError, err:
logging.warning("Can't read from device %s", path, exc_info=True)
iustin
