Comment #2 on issue 468 by [email protected]: "make lint" should report
wrongly-indented continuation lines
http://code.google.com/p/ganeti/issues/detail?id=468
http://www.python.org/dev/peps/pep-0008/#indentation says "Use 4 spaces per
indentation level.". PEP8 does not support anything else AFAIK.
As we have an indentation level of 2, we already ignore a couple of PEP8
errors. From Makefile.am:
# E111: indentation is not a multiple of four
# E121: continuation line indentation is not a multiple of four
# (since our indent level is not 4)
# E125: continuation line does not distinguish itself from next logical line
# (since our indent level is not 4)
# E127: continuation line over-indented for visual indent
# (since our indent level is not 4)
I'd actually prefer to change the codebase to match PEP8, and re-indent
everything to 4 spaces (I didn't check, but I assume there exist sensible
tools to do that). This would, on the other hand, create issues with line
lengths. Either we can also fix those automatically, or we discuss
increasing the maximum line length.
BTW, we already ignore the maximum line length error of PEP8 (because we
use 80, not the recommended 79).
In general I think that we could leverage more existing tools instead of
rebuilding them ourselves if we stick more strictly to the "official"
standard.
Thanks,
Thomas
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
