Re: [PATCH master 06/14] netutils: Add ValidatePortNumber method

[Santi Raffa]

On Thu, Dec 5, 2013 at 9:47 AM, Thomas Thrainer <thoma...@google.com> wrote:
> What is this line for?

I'm sure it felt like a good idea at some point :)

Interdiff:

diff --git a/lib/netutils.py b/lib/netutils.py
index d7afeb4..71c798f 100644
--- a/lib/netutils.py
+++ b/lib/netutils.py
@@ -271,15 +271,18 @@ def ValidatePortNumber(value):
   """Returns the validated integer port number if it is valid.

   @param value: the port number to be validated
+
   @raise ValueError: if the port is not valid
-  @return: the validated value as an integer."""
+  @rtype: int
+  @return: the validated value.
+
+  """

-  port = value
   try:
-    port = int(value)
+    port = int(port)
   except TypeError:
     raise errors.ProgrammerError("ValidatePortNumber called with non-numeric"
-                                 " type %s." % value.__class__.__name__)
+                                 " type %s." % port.__class__.__name__)
   except ValueError:
     raise ValueError("Invalid port value: '%s'" % port)

-- 
Raffa Santi
Google Germany GmbH
Dienerstr. 12
80331 München


Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Christine Elizabeth Flores

-- 
Raffa Santi
Google Germany GmbH
Dienerstr. 12
80331 München


Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Christine Elizabeth Flores