On Thu, Dec 5, 2013 at 10:27 AM, Santi Raffa <[email protected]> wrote:
> On Thu, Dec 5, 2013 at 9:47 AM, Thomas Thrainer <[email protected]> > wrote: > > What is this line for? > > I'm sure it felt like a good idea at some point :) > > Interdiff: > > diff --git a/lib/netutils.py b/lib/netutils.py > index d7afeb4..71c798f 100644 > --- a/lib/netutils.py > +++ b/lib/netutils.py > @@ -271,15 +271,18 @@ def ValidatePortNumber(value): > """Returns the validated integer port number if it is valid. > > @param value: the port number to be validated > + > @raise ValueError: if the port is not valid > - @return: the validated value as an integer.""" > + @rtype: int > + @return: the validated value. > + > + """ > ACK. > > - port = value > ACK. > try: > - port = int(value) > + port = int(port) > NACK. port is not defined here, right? > except TypeError: > raise errors.ProgrammerError("ValidatePortNumber called with > non-numeric" > - " type %s." % value.__class__.__name__) > + " type %s." % port.__class__.__name__) > NACK. port has no value here, right? > except ValueError: > raise ValueError("Invalid port value: '%s'" % port) > > -- > Raffa Santi > Google Germany GmbH > Dienerstr. 12 > 80331 München > > > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschäftsführer: Graham Law, Christine Elizabeth Flores > > -- > Raffa Santi > Google Germany GmbH > Dienerstr. 12 > 80331 München > > > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschäftsführer: Graham Law, Christine Elizabeth Flores > -- Thomas Thrainer | Software Engineer | [email protected] | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
