LGTM, thanks.
On Thu, Dec 5, 2013 at 2:34 PM, Santi Raffa <[email protected]> wrote: > On Thu, Dec 5, 2013 at 1:24 PM, Thomas Thrainer <[email protected]> > wrote: > > NACK. port is not defined here, right? > > Dammit! :) I forgot to also do this: > > diff --git a/lib/netutils.py b/lib/netutils.py > index 71c798f..0a70726 100644 > --- a/lib/netutils.py > +++ b/lib/netutils.py > @@ -267,10 +267,10 @@ class Hostname: > return hostname > > > -def ValidatePortNumber(value): > +def ValidatePortNumber(port): > """Returns the validated integer port number if it is valid. > > - @param value: the port number to be validated > + @param port: the port number to be validated > > @raise ValueError: if the port is not valid > @rtype: int > > -- > Raffa Santi > Google Germany GmbH > Dienerstr. 12 > 80331 München > > > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > Geschäftsführer: Graham Law, Christine Elizabeth Flores > -- Thomas Thrainer | Software Engineer | [email protected] | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
