Thanks, makes more sense to me. LGTM On Thu, Oct 8, 2015 at 3:41 PM Hrvoje Ribicic <[email protected]> wrote:
> On Mon, Oct 5, 2015 at 12:46 PM, Lisa Velden <[email protected]> wrote: > >> >> >> On Tue, Sep 29, 2015 at 5:21 PM, 'Hrvoje Ribicic' via ganeti-devel < >> [email protected]> wrote: >> >>> When a cluster is not to be created, the QA assumes that any nodes >>> listed in the QA definition file are actually there. It only makes >>> sense not to remove them from the cluster once the testing has been >>> completed, unless this was implicitly requested with the >>> "cluster-destroy" flag. >>> >> >> Was this supposed to be "It only makes sense to remove"? Otherwise the >> sentence is a bit confusing. >> > > No, the point of the patch was that nodes should be removed only if the > cluster should be destroyed, as the create-cluster test covers only the > creation and should leave the created cluster as-is, unless the destruction > was explicitly requested. > > That said, I can see how the patch description can confuse, and let me > suggest an alternative patch description (I'll break it into separate lines > later): > > The Ganeti QA can be set up to optionally both create and destroy a > cluster during its runtime. Before this patch, the QA removed all the nodes > barring the master one at the end of a QA, regardless of whether the > cluster was supposed to be disassembled. This patch fixes this behaviour > and lets created clusters remain in place after a QA. > > >> >>> >>> Signed-off-by: Hrvoje Ribicic <[email protected]> >>> --- >>> qa/ganeti-qa.py | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/qa/ganeti-qa.py b/qa/ganeti-qa.py >>> index 92ab27f..9c8a058 100755 >>> --- a/qa/ganeti-qa.py >>> +++ b/qa/ganeti-qa.py >>> @@ -1049,7 +1049,7 @@ def RunQa(): >>> >>> RunPerformanceTests() >>> >>> - RunTestIf("create-cluster", qa_node.TestNodeRemoveAll) >>> + RunTestIf("cluster-destroy", qa_node.TestNodeRemoveAll) >>> >>> RunTestIf("cluster-destroy", qa_cluster.TestClusterDestroy) >>> >>> -- >>> 2.6.0.rc2.230.g3dd15c0 >>> >>> >> >> >> -- >> Lisa Velden >> Software Engineer >> [email protected] >> >> Google Germany GmbH >> Dienerstraße 12 >> 80331 München >> >> Geschäftsführer: Graham Law, Christine Elizabeth Flores >> Registergericht und -nummer: Hamburg, HRB 86891 >> Sitz der Gesellschaft: Hamburg >> > > Hrvoje Ribicic > Ganeti Engineering > Google Germany GmbH > Dienerstr. 12, 80331, München > > > Geschäftsführer: Graham Law, Christine Elizabeth Flores > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > -- Lisa Velden Software Engineer [email protected] Google Germany GmbH Dienerstraße 12 80331 München Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg
