Please consider this changed log message:
commit fae23f511edb597182807ea7f83788ee20f7ed28
Author: Helga Velroyen <[email protected]>
Date: Tue Nov 10 11:02:41 2015 +0100
Disable --no-node-setup
This patch disables the option --no-node-setup of
'gnt-node add'. The option is the equivalent to
--no-ssh-init for 'gnt-cluster init'. However, it
was rather cumbersome for users to remember whether
or not the cluster was initialized with that to
not forget to use this option. Instead making the
user use --no-node-setup, Ganeti shall determine
whether or not to change the SSH setup by reading
the configuration parameter 'modify_ssh_setup' which
is set with --no-ssh-init.
Signed-off-by: Helga Velroyen <[email protected]>
and this interdiff:
diff --git a/lib/client/gnt_node.py b/lib/client/gnt_node.py
index 4aa5c62..b1ce8dc 100644
--- a/lib/client/gnt_node.py
+++ b/lib/client/gnt_node.py
@@ -314,7 +314,7 @@ def AddNode(opts, args):
if not opts.node_setup:
ToStdout("-- WARNING -- \n"
- "The option --no-node-setup is deprecated. Whether or not
the\n"
+ "The option --no-node-setup is disabled. Whether or not the\n"
"SSH setup is manipulated while adding a node is determined\n"
"by the 'modify_ssh_setup' value in the cluster-wide\n"
"configuration instead.\n")
On Thu, 12 Nov 2015 at 14:37 Klaus Aehlig <[email protected]> wrote:
> On Wed, Nov 11, 2015 at 04:02:03PM +0100, 'Helga Velroyen' via
> ganeti-devel wrote:
> > This patch deprecates the option --no-node-setup of
>
> s/deprecate/disable
>
> Note that "deprecate" means that it still works but we warn the user
> that it won't work in the next release; this patch, however, already
> disables the functionality. So the log message and the warning have
> to be reworded. Additionally, the change of semantics has also be
> reflected in the man page, not only the NEWS file (as done in the
> last patch).
>
> --
> Klaus Aehlig
> Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
> Registergericht und -nummer: Hamburg, HRB 86891
> Sitz der Gesellschaft: Hamburg
> Geschaeftsfuehrer: Matthew Scott Sucherman, Paul Terence Manicle
>
--
Helga Velroyen
Software Engineer
[email protected]
Google Germany GmbH
Dienerstraße 12
80331 München
Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind,
leiten Sie diese bitte nicht weiter, informieren Sie den Absender und
löschen Sie die E-Mail und alle Anhänge. Vielen Dank.
This e-mail is confidential. If you are not the right addressee please do
not forward it, please inform the sender, and please erase this e-mail
including any attachments. Thanks.
