Alright, will move the man page changes here.
On Fri, 13 Nov 2015 at 09:51 Klaus Aehlig <[email protected]> wrote:
> On Fri, Nov 13, 2015 at 08:45:30AM +0000, Helga Velroyen wrote:
> > So, here is the interdiff for patch 02, in addition to the changed log
> > message:
> >
> > diff --git a/lib/client/gnt_node.py b/lib/client/gnt_node.py
> > index 4aa5c62..b1ce8dc 100644
> > --- a/lib/client/gnt_node.py
> > +++ b/lib/client/gnt_node.py
> > @@ -314,7 +314,7 @@ def AddNode(opts, args):
> >
> > if not opts.node_setup:
> > ToStdout("-- WARNING -- \n"
> > - "The option --no-node-setup is deprecated. Whether or not
> > the\n"
> > + "The option --no-node-setup is disabled. Whether or not
> the\n"
> > "SSH setup is manipulated while adding a node is
> determined\n"
> > "by the 'modify_ssh_setup' value in the cluster-wide\n"
> > "configuration instead.\n")
>
> The changes to the man pages (as opposed to the NEWS file) probably also
> should
> go to patch 2 and not patch 4.
>
> The above change, plus the manpage changes sent out earlier, plus the
> suggested
> change of the log message LGTM.
>
> --
> Klaus Aehlig
> Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
> Registergericht und -nummer: Hamburg, HRB 86891
> Sitz der Gesellschaft: Hamburg
> Geschaeftsfuehrer: Matthew Scott Sucherman, Paul Terence Manicle
>
--
Helga Velroyen
Software Engineer
[email protected]
Google Germany GmbH
Dienerstraße 12
80331 München
Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind,
leiten Sie diese bitte nicht weiter, informieren Sie den Absender und
löschen Sie die E-Mail und alle Anhänge. Vielen Dank.
This e-mail is confidential. If you are not the right addressee please do
not forward it, please inform the sender, and please erase this e-mail
including any attachments. Thanks.
