+ganeti-devel On Fri, 13 Nov 2015 at 09:54 Helga Velroyen <[email protected]> wrote:
> Changed log message here: > commit 8626d89932277bccde8017e6e81e1d24fad2236d > Author: Helga Velroyen <[email protected]> > Date: Wed Nov 11 13:32:14 2015 +0100 > > Mention disabling of '--no-node-setup' in NEWS file > > Update the NEWS file regarding the disabling of > '--no-node-setup'. > > Signed-off-by: Helga Velroyen <[email protected]> > > > > On Fri, 13 Nov 2015 at 09:46 Helga Velroyen <[email protected]> wrote: > >> Consider this interdiff: >> >> diff --git a/NEWS b/NEWS >> index 3ff51ac..898a739 100644 >> --- a/NEWS >> +++ b/NEWS >> @@ -10,7 +10,7 @@ Version 2.16.0 beta2 >> Incompatible/important changes >> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> >> -- The options ``--no-node-setup`` of ``gnt-node add`` is deprecated. >> +- The options ``--no-node-setup`` of ``gnt-node add`` is disabled. >> Instead, the cluster configuration parameter ``modify_ssh_setup`` is >> used to determine whether or not to manipulate the SSH setup of a new >> node. >> >> diff --git a/man/gnt-cluster.rst b/man/gnt-cluster.rst >> index 7b0e135..b50d7d4 100644 >> --- a/man/gnt-cluster.rst >> +++ b/man/gnt-cluster.rst >> @@ -271,7 +271,10 @@ The ``--no-etc-hosts`` option allows you to >> initialize the cluster >> without modifying the /etc/hosts file. >> >> The ``--no-ssh-init`` option allows you to initialize the cluster >> -without creating or distributing SSH key pairs. >> +without creating or distributing SSH key pairs. This also sets the >> +cluster-wide configuration parameter ``modify ssh setup`` to False. >> +When adding nodes, Ganeti will consider this parameter to determine >> +whether to create and distributed SSH key pairs on new nodes as well. >> >> The ``--file-storage-dir``, ``--shared-file-storage-dir`` and >> ``--gluster-storage-dir`` options allow you set the directory to use for >> diff --git a/man/gnt-node.rst b/man/gnt-node.rst >> index 0940d7f..bf3fff3 100644 >> --- a/man/gnt-node.rst >> +++ b/man/gnt-node.rst >> @@ -62,13 +62,15 @@ The ``-g (--node-group)`` option is used to add the >> new node into a >> specific node group, specified by UUID or name. If only one node group >> exists you can skip this option, otherwise it's mandatory. >> >> -The ``--no-node-setup`` option prevents Ganeti from performing the >> -initial SSH setup on the new node. This means that Ganeti will not >> -touch the SSH keys or the ``authorized_keys`` file of the node at >> -all. Using this option, it lies in the administrators responsibility >> -to ensure SSH connectivity between the hosts by other means. Note, >> -that the equivalent of this option in ``gnt-cluster init`` is called >> -``--no-ssh-init``. >> +The ``--no-node-setup`` option that used to prevent Ganeti from >> performing >> +the initial SSH setup on the new node is no longer valid. Instead, >> +Ganeti consideres the ``modify ssh setup`` configuration parameter >> +(which is set using ``--no-ssh-init`` during cluster initialization) >> +to determine whether or not to do the SSH setup on a new node or not. >> +If this parameter is set to ``False``, Ganeti will not touch the SSH >> +keys or the ``authorized_keys`` file of the node at all. Using this >> option, >> +it lies in the administrators responsibility to ensure SSH connectivity >> +between the hosts by other means. >> >> The ``vm_capable``, ``master_capable``, ``ndparams``, ``diskstate`` and >> ``hvstate`` options are described in **ganeti**\(7), and are used to set >> >> >> >> On Thu, 12 Nov 2015 at 14:38 Klaus Aehlig <[email protected]> wrote: >> >>> >>> see comment on deprecate vs disable in review of patch 2. >>> Also, patch touching more than 5 lines without log message. >>> >>> -- >>> Klaus Aehlig >>> Google Germany GmbH, Dienerstr. 12, 80331 Muenchen >>> Registergericht und -nummer: Hamburg, HRB 86891 >>> Sitz der Gesellschaft: Hamburg >>> Geschaeftsfuehrer: Matthew Scott Sucherman, Paul Terence Manicle >>> >> -- >> >> Helga Velroyen >> Software Engineer >> [email protected] >> >> Google Germany GmbH >> Dienerstraße 12 >> 80331 München >> >> Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle >> Registergericht und -nummer: Hamburg, HRB 86891 >> Sitz der Gesellschaft: Hamburg >> >> Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind, >> leiten Sie diese bitte nicht weiter, informieren Sie den Absender und >> löschen Sie die E-Mail und alle Anhänge. Vielen Dank. >> >> This e-mail is confidential. If you are not the right addressee please do >> not forward it, please inform the sender, and please erase this e-mail >> including any attachments. Thanks. >> >> -- > > Helga Velroyen > Software Engineer > [email protected] > > Google Germany GmbH > Dienerstraße 12 > 80331 München > > Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg > > Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind, > leiten Sie diese bitte nicht weiter, informieren Sie den Absender und > löschen Sie die E-Mail und alle Anhänge. Vielen Dank. > > This e-mail is confidential. If you are not the right addressee please do > not forward it, please inform the sender, and please erase this e-mail > including any attachments. Thanks. > > -- Helga Velroyen Software Engineer [email protected] Google Germany GmbH Dienerstraße 12 80331 München Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind, leiten Sie diese bitte nicht weiter, informieren Sie den Absender und löschen Sie die E-Mail und alle Anhänge. Vielen Dank. This e-mail is confidential. If you are not the right addressee please do not forward it, please inform the sender, and please erase this e-mail including any attachments. Thanks.
