>>> On 9/12/2007 at 3:56 AM, in message <[EMAIL PROTECTED]>, Paul Millar <[EMAIL PROTECTED]> wrote: > Hi all, > > On Tuesday 11 September 2007 01:16:40 Bernard Li wrote: >> Information regarding Paul's patch: >> >> http://bugzilla.ganglia.info/cgi-bin/bugzilla/show_bug.cgi?id=120 >> >> Paul's patch is a bit big, so I'm still somewhat undecided whether I >> should include this for 3.0.5, or save it for 3.1.0... thoughts? >> >> I have tested this under CentOS 4 without any noticeable issues. > > Hmmm, I'm not sure myself. > > The impact on deployed systems (beyond the extra code) is that the RRD > filenames for metrics with a "%" in their metric name will change: for > example, instead of storing metric data for "foo%" as "foo%.rrd", it will be > > stored as "foo%25.rrd". > > I suspect very few people will have metrics with a "%" in the name; this > change is probably not much of a problem in practice. The patch *probably* > could be deployed for 3.0.5, but the safer option would be to delay the > patch > for the 3.1.x branch. >
Actually I would suggest the other way around. The 3.0.5 branch is the stable branch and if this patch could destabilize it, then the patch shouldn't be deployed there. However, trunk is where all new development or patches are going. If the patch needs to be tested and proved still, then it should probably going into trunk. Brad ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
