Hi Carlo: On 11/6/07, Carlo Marcelo Arenas Belon <[EMAIL PROTECTED]> wrote:
> I don't think that error is linked to the "multicpu" module directly, > but the fact that the kernel doesn't have "cpufreq" ACPI governor loaded, and > therefore there is an error since your changes in r815 to lib/file.c for any > related metric. I wouldn't go that far and call this an "error". However, I do not think that the code should assume that this ACPI feature is enabled in the kernel. > looking at the archive it might seem that this issue was raised in : > > http://www.mail-archive.com/ganglia-developers@lists.sourceforge.net/msg02945.html > > but the additional fix was never tested/deployed Perfect time to address it again then :) > attached a fix that was tested working in my athlon64 laptop running gentoo > linux 2007.0 with and without powernow-k8. a similar fix will need to be done > for the multicpu code unless changes in r815 are reverted and then we go back > to slurpfile silent to errors (but leaving that to the caller as being used > everywhere else). Had a quick glance at the patch -- looks okay. Please feel free to check it in. BTW, I don't understand what you were referring to about the changes in r815: http://ganglia.svn.sourceforge.net/viewvc/ganglia/trunk/monitor-core/lib/file.c?r1=394&r2=815 All I did was include the filename that was causing the error, it was never 'silent' to begin with. So instead of getting the message: GMOND[31539]: slurpfile() open() error on file /sys/devices/system/cpu/cpu0/cpufreq/scaling_max_freq: No such file or directory it would have read: GMOND[31539]: slurpfile() open() error: No such file or directory Regards, Bernard ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
