Bernard Li wrote: > Hi Jesse: > > On 2/8/08, Jesse Becker <[EMAIL PROTECTED]> wrote: > >> Slightly different approaches. The r926 patch adds a new subroutine >> in functions.php. The one I just posted fixes an existing one. Take >> your pick. >> >> I actually think that using is_numeric() is a better solution, rather >> than using a regex. > > Okay, you guys work out the best approach and fire me a patch. Better > yet, file a bug in bugzilla and put it there (feel free to assign me > to it). Please supply patches for both branch and trunk. > > With the number of patches that have been showing up in the list > lately, some are bound to be lost if not tracked properly. > > Thanks, > > Bernard
I filed 2 bugs and assigned them to you. First to remove some debugging code from conf.php in trunk. Second to fix the input filtering functions - I attached patches for both trunk and 30-beta. They use is_numeric() rather than ctype_digit() or preg_match(). http://bugzilla.ganglia.info/cgi-bin/bugzilla/show_bug.cgi?id=177 http://bugzilla.ganglia.info/cgi-bin/bugzilla/show_bug.cgi?id=178 alex ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
