>>> On 4/18/2008 at 7:50 PM, in message <[EMAIL PROTECTED]>, Carlo Marcelo Arenas Belon <[EMAIL PROTECTED]> wrote: > On Fri, Apr 18, 2008 at 02:01:41PM -0600, Brad Nicholes wrote: >> I've just added a backport proposal in the monitor-core-3.1 branch STATUS > file for including a check for the module magic number. Please check out the > proposal in the STATUS file and vote. You don't necessarily have to vote > within the STATUS file itself, but you can or you can just vote through the > devel list. > > +1 > > but since this is going to be the first version of the API release, it will > be > most likely also better to apply as well the following patch so that we can > start with a clean slate > > Carlo > --- > Index: include/gm_mmn.h > =================================================================== > --- include/gm_mmn.h (revision 1259) > +++ include/gm_mmn.h (working copy) > @@ -16,16 +16,13 @@ > */ > > /* > - * 20070222.0 (3.1.0-dev) MODULE_MAGIC_COOKIE set to "GM31" > - * 20070918.0 (3.1.0-dev) mmodule_struct change. Pass parameter list > - * C interface modules and python modules. Allow > - * configuration file access from a C module. > + * 1.0 (3.1.0-dev) MODULE_MAGIC_COOKIE set to "GM31", first modular release > */ > > #define MMODULE_MAGIC_COOKIE 0x474D3331UL /* "GM31" */ > > #ifndef MMODULE_MAGIC_NUMBER_MAJOR > -#define MMODULE_MAGIC_NUMBER_MAJOR 20070918 > +#define MMODULE_MAGIC_NUMBER_MAJOR 1 > #endif > #define MMODULE_MAGIC_NUMBER_MINOR 0 /* 0...n */ >
I have resisted doing the above simply for historical reasons. Also the MMODULE_MAGIC_NUMBER_MAJOR carries the date so that it is easier to correlate when the incompatible change was made and what it was, rather than having to search back through SVN. The SVN number could be used but you don't know what that number is until you actually check in the code. Also the SVN number could be different between a trunk checkin and a branch checkin. Since the magic number simply has to be a number, using the date just helps to facilitate tracking. Besides we want to keep the numbers consistent between trunk and branches. Just because there is a version difference, doesn't mean that the modular API is incompatible. Also, resetting the number back to 1 will throw off the magic number check in the source code. Trunk should always equal to are greater than any branch. Anyway, this is how Apache has been tracking its modules and interface compatibility. So far it has worked out pret ty good. Brad ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
