On Fri, Jul 18, 2008 at 07:33:23PM -0400, Jason A. Smith wrote: > > This patch takes the max_graphs option from the conf.php file and > makes it configurable on the web interface.
Not sure if that is the right thing to do, as it would seem that a user configurable max_graphs would make more sense integrated with an already available user configurable show_hosts. The original intention for "max_graphs" was probably as a system configuration to reduce the load in the web server to generate all the graphs for a cluster that has way too many nodes and making this user configurable will defeat that purpose. > - The number of metric columns in the host view is now configurable > in both the conf.php file and through the web interface. Committed revision 1583 for trunk > - The default hostcols from the cluster view was added to conf.php. Committed revision 1582 for trunk > - All of these values are now saved while navigating through the > web interface via params in the URLs and hidden form values. Not sure if a good idea, as using hidden form values doesn't allow for URLs that are completely representative of the parameters needed to build the page and therefore will prevent people sending around ganglia URLs that are meaningful. Agree that the URL is getting polluted and this could be a way to solve that problem, but as you point our implicitly in your patch, our current handling of GET variables is incomplete, and adding yet another parameter passing mechanism will make it even more obscure (BTW we also use cookies in a somehow buggy way as well for the same reason). > - Fixed a minor bug where the metric shown in the cluster view > wasn't saved while navigating around (wrong variable name). Committed revision 1567 for trunk Carlo ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Ganglia-developers mailing list Ganglia-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ganglia-developers
