------- Comment #32 from chrbr at gcc dot gnu dot org 2010-02-05 07:05 ------- > Looks smart and clean! One minor nit, I guess that the occurence of > gbr and GBR in ChangeLog and comments should be replaced with GOT to > avoid confusion with GBR register of SH CPU.
Thanks for catching up this error in the comment. I meant GP of course, which is even more preferable that GOT (which is what we load, not what we compute). (In reply to comment #31) > When you propose it to the list, could you please separate the third > hunk which is for the original PR42841 as an independant patch. Also > don't forget to update the copyright years in the first one. > OK, that was also my intention to submit the 3rd hunk (the one that fixes the jump to the landing pad around the constant table right ?) as a separate patch as it will require the approval of a middle end maintainer. If it cannot go in the trunk before the 4.5 freeze I can propose you to commit your workaround (comment #23) so not to block the regression. Then we can revert when the proper patch is discussed/accepted. (I'm a little bit late for that sorry). -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42841