On 04/17/2015 09:17 AM, Jan Kratochvil wrote:
Hi,
ping:
[gcc patch] libcc1: '@' GDB array operator
https://gcc.gnu.org/ml/gcc-patches/2015-03/msg01451.html
Message-ID: <20150327163646.ga16...@host1.jankratochvil.net>
Jan
Sorry this has taken so long to get back to... We're still digging out
a bit from the patches queued while preparing for the gcc5 release.
So I guess at some level it's not clear to me why we need to support the
@ operator in libcc1. So perhaps starting with a justification for
wanting/needed that capability would be helpful. And just to be clear,
I'm an avid fan of '@' in gdb, so you can assume I already know what it
does and accept that it's a good thing in gdb.
As for the patch itself, you noted you weren't sure if copy_node was
right, it would help if you'd describe what problem you were having
that's solved by copying the node. I wonder if you should be building up
a node from scratch here.
In general, please use C style comments rather than C++. It's a nit and
may change one day, but the general consensus has been to stick with
old-style comments for now.
Jeff
