On Sun, 23 Apr 2023, Segher Boessenkool wrote: > 1) Targets that already always have LRA, but that redefine the hook > anyway. These are gcn, pdp11, rx, sparc, vax, and xtensa. Nothing > really changes for these targets with this patch (but later patches > will delete the superfluous hook implementations).
Umm, no, VAX has LRA selectable and for a reason it defaults to off: > diff --git a/gcc/config/vax/vax.cc b/gcc/config/vax/vax.cc > index 82a176d3bfc9..17fdc4483797 100644 > --- a/gcc/config/vax/vax.cc > +++ b/gcc/config/vax/vax.cc > @@ -114,9 +114,6 @@ static HOST_WIDE_INT vax_starting_frame_offset (void); > #undef TARGET_STRUCT_VALUE_RTX > #define TARGET_STRUCT_VALUE_RTX vax_struct_value_rtx > > -#undef TARGET_LRA_P > -#define TARGET_LRA_P vax_lra_p > - There are extra ICEs in regression testing and code quality is poor; cf. <https://gcc.gnu.org/pipermail/gcc-patches/2022-January/588296.html>. I'll have a look into it sometime, but it may not be soon and the broken VAX exception unwinder is more important and will have to take precedence anyway. I have fixing the unwinder scheduled hopefully for this release cycle, but LRA will have to wait. Maciej
