> -----Original Message----- > From: Gcc-patches <gcc-patches- > bounces+kyrylo.tkachov=arm....@gcc.gnu.org> On Behalf Of Tamar > Christina via Gcc-patches > Sent: Tuesday, May 2, 2023 8:08 AM > To: Jeff Law <jeffreya...@gmail.com>; gcc-patches@gcc.gnu.org > Cc: nd <n...@arm.com>; bonz...@gnu.org; nero...@gcc.gnu.org; > aol...@gcc.gnu.org; ralf.wildenh...@gmx.de > Subject: RE: [PATCH 5/5] match.pd: Use splits in makefile and make > configurable. > > > -----Original Message----- > > From: Jeff Law <jeffreya...@gmail.com> > > Sent: Sunday, April 30, 2023 8:46 PM > > To: Tamar Christina <tamar.christ...@arm.com>; gcc-patches@gcc.gnu.org > > Cc: nd <n...@arm.com>; bonz...@gnu.org; nero...@gcc.gnu.org; > > aol...@gcc.gnu.org; ralf.wildenh...@gmx.de > > Subject: Re: [PATCH 5/5] match.pd: Use splits in makefile and make > > configurable. > > > > > > > > On 4/28/23 04:44, Tamar Christina via Gcc-patches wrote: > > > Hi All, > > > > > > This updates the build system to split up match.pd files into chunks of > > > 10. > > > This also introduces a new flag --with-matchpd-partitions which can be > > > used to change the number of partitions. > > > > > > For the analysis of why 10 please look at the previous patch in the > > > series. > > > > > > Bootstrapped Regtested on aarch64-none-linux-gnu and no issues. > > > > > > Ok for master? > > > > > > Thanks, > > > Tamar > > > > > > gcc/ChangeLog: > > > > > > PR bootstrap/84402 > > > * Makefile.in (NUM_MATCH_SPLITS, MATCH_SPLITS_SEQ, > > > GIMPLE_MATCH_PD_SEQ_SRC, GIMPLE_MATCH_PD_SEQ_O, > > > GENERIC_MATCH_PD_SEQ_SRC, GENERIC_MATCH_PD_SEQ_O): New. > > > (OBJS, MOSTLYCLEANFILES, .PRECIOUS): Use them. > > > (s-match): Split into s-generic-match and s-gimple-match. > > > * configure.ac (with-matchpd-partitions, > > > DEFAULT_MATCHPD_PARTITIONS): New. > > > * configure: Regenerate. > > This looks pretty reasonable to me. Are there any patches left in this > > series > > that need review? I'm very much looking forward to build time provements > > related to this patch, particularly for targets that I bootstrap with qemu > > emulation -- we take multiple hours to build gimple-match and the ability to > > parallelize those component builds should be a significant win. > > Hi, > > No this is the last one, Richi already approved the rest but he didn't feel he > had > enough knowledge about the build system to say if this code was portable > enough.
I'm looking forward to this going as well for improved bootstrap times, thanks for working on this! > > So just waiting on this one and can commit the series. Can we treat Jeff's LGTM above as an ok given his global reviewer position? Thanks, Kyrill > > Cheers, > Tamar > > > > jeff
