Thanks for catching and fixing David and Andrew. Drew
On Tue, Jul 25, 2023 at 5:59 PM Andrew Pinski <pins...@gmail.com> wrote: > On Tue, Jul 25, 2023 at 1:54 PM Andrew Pinski <pins...@gmail.com> wrote: > > > > On Tue, Jul 25, 2023 at 12:45 PM Jakub Jelinek via Gcc-patches > > <gcc-patches@gcc.gnu.org> wrote: > > > > > > On Tue, Jul 25, 2023 at 03:42:21PM -0400, David Edelsohn via > Gcc-patches wrote: > > > > Hi, Drew > > > > > > > > Thanks for addressing this missed optimization. > > > > > > > > The testcase includes an incorrect assumption: signed char, which > > > > causes the testcase to fail on PowerPC. > > > > > > > > Should the testcase be updated to specify signed char in the function > > > > signatures or should -fsigned-char be added to the command line > > > > options? > > > > > > I think we should use signed char instead of char in the testcase. > > > > I also think it should be `signed char` instead as I mentioned in > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110803 . > > Committed the testsuite fix as r14-2767-g67357270772b91 . > > Thanks, > Andrew > > > > > Thanks, > > Andrew > > > > > > > > Jakub > > > > >
